Re: [PATCH 2/3 v2] nvme: add rotational support

[Christoph Hellwig]

On Thu, Oct 10, 2024 at 02:39:50PM +0200, Matias Bjørling wrote:
> From: Wang Yugui <wangyugui@xxxxxxxxxxxx>
> 
> Rotational devices, such as hard-drives, can be detected using
> the rotational bit in the namespace independent identify namespace
> data structure. Make the bit visible to the block layer through the
> rotational queue setting.
> 
> Signed-off-by: Wang Yugui <wangyugui@xxxxxxxxxxxx>
> Reviewed-by: Matias Bjørling <matias.bjorling@xxxxxxx>

If you pass this on, this should be a Signed-off-by.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

> larlar

?