Re: [PATCH] ALSA: hda/cs8409: Fix possible NULL dereference

From: Takashi Iwai
Date: Fri Oct 11 2024 - 05:13:35 EST


On Fri, 11 Oct 2024 00:16:45 +0200,
Murad Masimov wrote:
>
> If snd_hda_gen_add_kctl fails to allocate memory and returns NULL, then
> NULL pointer dereference will occur in the next line.
>
> Since dolphin_fixups function is a hda_fixup function which is not supposed
> to return any errors, add simple check before dereference, ignore the fail.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 20e507724113 ("ALSA: hda/cs8409: Add support for dolphin")
> Signed-off-by: Murad Masimov <m.masimov@xxxxxxxxx>

Thanks, applied.


Takashi