Re: [PATCH net] pktgen: Avoid out-of-range in get_imix_entries

From: Artem Chernyshev
Date: Fri Oct 11 2024 - 05:21:15 EST


Thank you for the review. I will return with V2

Best regards,
Artem

On Tue, Oct 08, 2024 at 06:23:19PM -0700, Jakub Kicinski wrote:
> On Mon, 7 Oct 2024 01:12:20 +0300 Artem Chernyshev wrote:
> > In get_imit_enries() pkt_dev->n_imix_entries = MAX_IMIX_ENTRIES
> > leads to oob for pkt_dev->imix_entries array.
>
> I don't think so, at least not exactly. It's legal to fill the array
> completely. It's not legal to try to _add_ to an already full array.
>
> AFAICT the fix needs more work.
> --
> pw-bot: cr