RE: [EXTERNAL] Re: [PATCH v1] Upload dsp firmware for ASUS laptop 1EB30 & 1EB31 and Update WHENCE for both
From: Ding, Shenghao
Date: Fri Oct 11 2024 - 05:23:59 EST
Hi Mario
Thanks for your support. Finally "make check" works, following is the log.
root@LAPTOP-70RJ5B8Q:/usr/local/src/fw_new# make check
Check that executables have shebangs.....................................Passed
Forbid new submodules....................................................Passed
Check Yaml...............................................................Passed
Check for broken symlinks............................(no files to check)Skipped
Detect Destroyed Symlinks................................................Passed
shellcheck...............................................................Passed
black....................................................................Passed
markdownlint............................................................Skipped
Check whence.............................................................Passed
root@LAPTOP-70RJ5B8Q:/usr/local/src/fw_new#
> On 10/10/24 08:30, Mario Limonciello wrote:
> >> Although TAS2XXX1EB30.bin and TAS2XXX1EB31.bin are both in
> >> ti/tas2781, yet it reported "does not exist".
> >> I have no idea why the file is there while report "does not exist".
> >> After I removed the newly-merged, no such report.
> >
> > I think you forgot to git add them to the commit?
> >
> >>
................................
> I'll merge this and if you have any follow ups you can do them on top as future
> MR (preferred!) or patches to M/L.
It seemed that I was not used to submitting patch via gitlab.
So, finally I have to submit the patch to the git.kernel.com
I'll try submitting next firmware binary file via Gitlab. Thanks.
>
> Thanks!