Re: [PATCH v1 1/5] libperf cpumap: Correct reference count for perf_cpu_map__merge()

[Leo Yan]

On 10/11/24 10:46, Adrian Hunter wrote:

[...]

> > > > int perf_cpu_map__merge_in(struct perf_cpu_map **orig, struct perf_cpu_map *other)
> > > > {
> > > >           struct perf_cpu_map *result = perf_cpu_map__merge(*orig, other);
> > > >
> > > >           if (!result)
> > > >                   return -ENOMEM;
> > > >
> > > >           *orig = result;
> > > >           return 0;
> > > > }
> > > >
> > > > without any changes to perf_cpu_map__merge().
> > >
> > > Just wandering why we cannot do the same thing for the perf_cpu_map__merge()
> > > function?
> > >
> > >     int perf_cpu_map__merge_in(struct perf_cpu_map **orig,
> > >                                struct perf_cpu_map *other)
> >
> > Sorry for typo and spamming. The above suggested definition is for perf_cpu_map__merge().
>
> Yes - there is not much reason to have perf_cpu_map__merge()
> and perf_cpu_map__merge_in().

Thanks for suggestion!  Will move towards this.

Leo