Re: [PATCH 1/7] iommu/vt-d: Add domain_alloc_paging support

From: Jason Gunthorpe
Date: Fri Oct 11 2024 - 09:23:56 EST


On Fri, Oct 11, 2024 at 12:27:16PM +0800, Lu Baolu wrote:

> +static struct iommu_domain *intel_iommu_domain_alloc_paging(struct device *dev)
> +{
> + struct dmar_domain *dmar_domain;
> + bool first_stage;
> +
> + first_stage = first_level_by_default(0);
> + dmar_domain = paging_domain_alloc(dev, first_stage);
> + if (IS_ERR(dmar_domain))
> + return ERR_CAST(dmar_domain);
> +
> + return &dmar_domain->domain;
> +}

With the direction that Vasant's series is going in, I think this
should be skipped and instead your other patch to make
domain_alloc_user (which we will rename) a full functional replacement
is the right thing.

Jason