Re: [PATCH v6 3/8] dt-bindings: PCI: qcom,pcie-x1e80100: Add 'global' interrupt

From: Krzysztof Kozlowski
Date: Fri Oct 11 2024 - 10:34:17 EST


On Fri, Oct 11, 2024 at 03:41:37AM -0700, Qiang Yu wrote:
> Document 'global' SPI interrupt along with the existing MSI interrupts so
> that QCOM PCIe RC driver can make use of it to get events such as PCIe
> link specific events, safety events, etc.

Describe the hardware, not what the driver will do.

>
> Though adding a new interrupt will break the ABI, it is required to
> accurately describe the hardware.

That's poor reason. Hardware was described and missing optional piece
(because according to your description above everything was working
fine) is not needed to break ABI.

Sorry, if your driver changes the ABI for this poor reason.

NAK.

Best regards,
Krzysztof