Re: [PATCH 2/2] rtla/timerlat: Make timerlat_hist_cpu->*_count unsigned long long

[John Kacur]

On Fri, 11 Oct 2024, tglozar@xxxxxxxxxx wrote:

> From: Tomas Glozar <tglozar@xxxxxxxxxx>
> 
> Do the same fix as in previous commit also for timerlat-hist.
> 
> Reported-by: Attila Fazekas <afazekas@xxxxxxxxxx>
> Signed-off-by: Tomas Glozar <tglozar@xxxxxxxxxx>
> ---
>  tools/tracing/rtla/src/timerlat_hist.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/tools/tracing/rtla/src/timerlat_hist.c b/tools/tracing/rtla/src/timerlat_hist.c
> index a3907c390d67..bbeaba8b5183 100644
> --- a/tools/tracing/rtla/src/timerlat_hist.c
> +++ b/tools/tracing/rtla/src/timerlat_hist.c
> @@ -62,9 +62,9 @@ struct timerlat_hist_cpu {
>  	int			*thread;
>  	int			*user;
>  
> -	int			irq_count;
> -	int			thread_count;
> -	int			user_count;
> +	unsigned long long	irq_count;
> +	unsigned long long	thread_count;
> +	unsigned long long	user_count;
>  
>  	unsigned long long	min_irq;
>  	unsigned long long	sum_irq;
> @@ -304,15 +304,15 @@ timerlat_print_summary(struct timerlat_hist_params *params,
>  			continue;
>  
>  		if (!params->no_irq)
> -			trace_seq_printf(trace->seq, "%9d ",
> +			trace_seq_printf(trace->seq, "%9llu ",
>  					data->hist[cpu].irq_count);
>  
>  		if (!params->no_thread)
> -			trace_seq_printf(trace->seq, "%9d ",
> +			trace_seq_printf(trace->seq, "%9llu ",
>  					data->hist[cpu].thread_count);
>  
>  		if (params->user_hist)
> -			trace_seq_printf(trace->seq, "%9d ",
> +			trace_seq_printf(trace->seq, "%9llu ",
>  					 data->hist[cpu].user_count);
>  	}
>  	trace_seq_printf(trace->seq, "\n");
> @@ -488,15 +488,15 @@ timerlat_print_stats_all(struct timerlat_hist_params *params,
>  		trace_seq_printf(trace->seq, "count:");
>  
>  	if (!params->no_irq)
> -		trace_seq_printf(trace->seq, "%9d ",
> +		trace_seq_printf(trace->seq, "%9llu ",
>  				 sum.irq_count);
>  
>  	if (!params->no_thread)
> -		trace_seq_printf(trace->seq, "%9d ",
> +		trace_seq_printf(trace->seq, "%9llu ",
>  				 sum.thread_count);
>  
>  	if (params->user_hist)
> -		trace_seq_printf(trace->seq, "%9d ",
> +		trace_seq_printf(trace->seq, "%9llu ",
>  				 sum.user_count);
>  
>  	trace_seq_printf(trace->seq, "\n");
> -- 
> 2.47.0
> 
> 
> 
Reviewed by: John Kacur <jkacur@xxxxxxxxxx>
Tested by: John Kacur <jkacur@xxxxxxxxxx>