Re: [PATCH] ASoC: qcom: sdm845: add missing soundwire runtime stream alloc
From: Alexey Klimov
Date: Fri Oct 11 2024 - 11:39:17 EST
On Thu Oct 10, 2024 at 6:18 AM BST, Krzysztof Kozlowski wrote:
> On 09/10/2024 23:39, Alexey Klimov wrote:
> > During the migration of Soundwire runtime stream allocation from
> > the Qualcomm Soundwire controller to SoC's soundcard drivers the sdm845
> > soundcard was forgotten.
> >
> > At this point any playback attempt or audio daemon startup, for instance
> > on sdm845-db845c (Qualcomm RB3 board), will result in stream pointer
> > NULL dereference:
>
> ...
>
> >
> > Reproduced and then fix was tested on db845c RB3 board.
> >
> > Reported-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> > Fixes: 15c7fab0e047 ("ASoC: qcom: Move Soundwire runtime stream alloc to soundcards")
> > Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Cc: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> > Signed-off-by: Alexey Klimov <alexey.klimov@xxxxxxxxxx>
> > ---
>
> We should fix this everywhere, not only sdm845. I'll look at remaining
> sc7280.
What about sc7180? Or is sc7180 one the platforms where soundwire is not used
and DSP is not involved?
Anyway, I don't have hw to test sc7180 or sc7280.
Thank you,
Alexey