Re: [PATCH v6 1/2] x86, KVM:SVM: Move sev specific parsing into arch/x86/virt/svm
From: Tom Lendacky
Date: Fri Oct 11 2024 - 12:35:51 EST
On 10/11/24 11:21, Borislav Petkov wrote:
> On Thu, Oct 10, 2024 at 07:14:54AM -0500, Pavan Kumar Paluri wrote:
>> Move SEV specific kernel command line option parsing support from
>> arch/x86/coco/sev/core.c to arch/x86/virt/svm/cmdline.c so that both
>> host and guest related SEV command line options can be supported.
>>
>> No functional changes intended.
>>
>> Signed-off-by: Pavan Kumar Paluri <papaluri@xxxxxxx>
>> Reviewed-by: Tom Lendacky <thomas.lendacky@xxxxxxx>
>> ---
>> arch/x86/coco/sev/core.c | 44 -------------------------------
>> arch/x86/include/asm/sev-common.h | 27 +++++++++++++++++++
>> arch/x86/virt/svm/Makefile | 1 +
>> arch/x86/virt/svm/cmdline.c | 32 ++++++++++++++++++++++
>> 4 files changed, 60 insertions(+), 44 deletions(-)
>> create mode 100644 arch/x86/virt/svm/cmdline.c
>
> make[5]: *** No rule to make target 'arch/x86/virt/svm/cmdline.o', needed by 'arch/x86/virt/svm/built-in.a'. Stop.
> make[5]: *** Waiting for unfinished jobs....
> make[4]: *** [scripts/Makefile.build:478: arch/x86/virt/svm] Error 2
> make[3]: *** [scripts/Makefile.build:478: arch/x86/virt] Error 2
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [scripts/Makefile.build:478: arch/x86] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/mnt/kernel/kernel/linux/Makefile:1936: .] Error 2
> make: *** [Makefile:224: __sub-make] Error 2
>
> $ ls arch/x86/virt/svm/cmdline.c
> ls: cannot access 'arch/x86/virt/svm/cmdline.c': No such file or directory
>
> Looks like you forgot to git add cmdline.c before committing.
But the patch includes the new file, so how can that be?
Thanks,
Tom
>