Re: [PATCH v2] wifi: ath10k: add channel 177 for 5 GHz band

[Jeff Johnson]

On 10/8/2024 11:49 PM, Paweł Owoc wrote:> Add support for channel 177 (5885
MHz ) for the 5 GHz band.
> 
> Tested-on: qca988x hw2.0 firmware ver 10.2.4-1.0-00047

Can you elaborate on what was tested in your commit text? And more
importantly, what is the impact on existing devices, especially given that
existing devices would not have calibration data for this channel in the board
files? Does the QCA988x board file even have calibration data for this channel?

> 
> Signed-off-by: Paweł Owoc <frut3k7@xxxxxxxxx>
> ---

what is the diff from v1?
for future reference when you submit a new version of a patch you should
include a patch changelog after the ---, see:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format

>  drivers/net/wireless/ath/ath10k/core.h | 4 ++--
>  drivers/net/wireless/ath/ath10k/mac.c  | 1 +
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
> index 446dca74f06a..3dff8c028526 100644
> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -39,8 +39,8 @@
>  #define WMI_READY_TIMEOUT (5 * HZ)
>  #define ATH10K_FLUSH_TIMEOUT_HZ (5 * HZ)
>  #define ATH10K_CONNECTION_LOSS_HZ (3 * HZ)
> -#define ATH10K_NUM_CHANS 41
> -#define ATH10K_MAX_5G_CHAN 173
> +#define ATH10K_NUM_CHANS 42
> +#define ATH10K_MAX_5G_CHAN 177
>  
>  /* Antenna noise floor */
>  #define ATH10K_DEFAULT_NOISE_FLOOR -95
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index 646e1737d4c4..cee6a4d287b5 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -9543,6 +9543,7 @@ static const struct ieee80211_channel ath10k_5ghz_channels[] = {
>  	CHAN5G(165, 5825, 0),
>  	CHAN5G(169, 5845, 0),
>  	CHAN5G(173, 5865, 0),
> +	CHAN5G(177, 5885, 0),
>  	/* If you add more, you may need to change ATH10K_MAX_5G_CHAN */
>  	/* And you will definitely need to change ATH10K_NUM_CHANS in core.h */
>  };