Re: [PATCH v6 1/2] x86, KVM:SVM: Move sev specific parsing into arch/x86/virt/svm

From: Paluri, PavanKumar
Date: Fri Oct 11 2024 - 13:09:04 EST


Hello Boris,

On 10/11/2024 11:59 AM, Borislav Petkov wrote:
> On Fri, Oct 11, 2024 at 11:55:14AM -0500, Tom Lendacky wrote:
>> Ah, that makes more sense. Looks like he's missing the include for
>> linux/cache.h
>
> "Changelog:
> =========
> v5:
> ...
> * Remove <asm/cache.h> stray header introduced in the previous
> versions because of __read_mostly attribute that is now moved into
> virt/svm/cmdline.c"
>

Yes, I am very sorry. I should have done a progressive build, which
could have helped me in spotting this issue.

This changelog points at removing <asm/cache.h> from
arch/x86/include/asm/sev-common.h (where __read_mostly was previously
present) and forgot to include this header to where it is now relocated
to. I will address this. On building the patchset (1 and 2 together), I
do not see the error, so this should have occurred on just building
Patch #1.

Thanks for the review.
Pavan