Re: [PATCH v8 20/25] x86/resctrl: Report "Unassigned" for MBM events in mbm_cntr_assign mode

From: Tony Luck
Date: Fri Oct 11 2024 - 13:23:39 EST


On Wed, Oct 09, 2024 at 12:39:45PM -0500, Babu Moger wrote:
> @@ -576,6 +576,15 @@ int rdtgroup_mondata_show(struct seq_file *m, void *arg)
> evtid = md.u.evtid;
> r = &rdt_resources_all[resid].r_resctrl;
>
> + if (resctrl_arch_mbm_cntr_assign_enabled(r) && evtid != QOS_L3_OCCUP_EVENT_ID) {

Better to write this as:

if (resctrl_arch_mbm_cntr_assign_enabled(r) && is_mbm_event(evtid)) {

-Tony