Re: [PATCH v2 rcu 13/13] srcu: Improve srcu_read_lock_lite() kernel-doc comment

From: Andrii Nakryiko
Date: Fri Oct 11 2024 - 13:57:37 EST


On Fri, Oct 11, 2024 at 10:39 AM Paul E. McKenney <paulmck@xxxxxxxxxx> wrote:
>
> Where RCU is watching is where it is OK to invoke rcu_read_lock().
>
> Reported-by: Andrii Nakryiko <andrii@xxxxxxxxxx>
> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxx>
> ---
> include/linux/srcu.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>

Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx>

> diff --git a/include/linux/srcu.h b/include/linux/srcu.h
> index 4ba96e2cfa405..bab1dae3f69e6 100644
> --- a/include/linux/srcu.h
> +++ b/include/linux/srcu.h
> @@ -270,7 +270,8 @@ static inline int srcu_read_lock(struct srcu_struct *ssp) __acquires(ssp)
> * synchronize_rcu_expedited(), IPIs and all.
> *
> * Note that srcu_read_lock_lite() can be invoked only from those contexts
> - * where RCU is watching. Otherwise, lockdep will complain.
> + * where RCU is watching, that is, from contexts where it would be legal
> + * to invoke rcu_read_lock(). Otherwise, lockdep will complain.
> */
> static inline int srcu_read_lock_lite(struct srcu_struct *ssp) __acquires(ssp)
> {
> --
> 2.40.1
>