Re: [PATCH v1 07/13] iio: chemical: bme680: add regulators

[Vasileios Aoiridis]

On Fri, Oct 11, 2024 at 01:05:06PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 10, 2024 at 11:00:24PM +0200, vamoirid wrote:
> > From: Vasileios Amoiridis <vassilisamir@xxxxxxxxx>
> > 
> > Add support for the regulators described in the dt-binding.
> 
> ...
> 
> > +static const char *const bme680_supply_names[] = {
> > +	"vdd", "vddio"
> 
> Leave trailing comma.
>

ACK.

> > +};
> 
> ...
> 
> > +	devm_add_action_or_reset(dev, bme680_regulators_disable, data->supplies);
> 
> No error check?! Why?
>

You are right, I should put it, I probably didnit see it!

> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

Cheers,
Vasilis