Re: [PATCH v1 13/13] iio: chemical: bme680: Add support for preheat current

[Vasileios Aoiridis]

On Fri, Oct 11, 2024 at 01:39:29PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 10, 2024 at 11:00:30PM +0200, vamoirid wrote:
> > From: Vasileios Amoiridis <vassilisamir@xxxxxxxxx>
> > 
> > Add functionality to inject a specified amount of current to the heating
> > plate before the start of the gas measurement to allow the sensor to reach
> > faster to the requested temperature.
> 
> ...
> 
> > +	data->preheat_curr = 0; /* milliamps */
> 
> Instead of the comment, make it better to any appearance of the variable in the
> code by adding unit suffix.
> 
> 	data->preheat_curr_mA = 0;
> 
> (yes, capital 'A').
> 

Hi Andy,

I used the comment here because it is exactly like this above and I
though it is more consistent if I do the same. But I guess repeating a
not so good design choice for consistency might not be the best
decision.

Cheers,
Vasilis
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>