Re: [PATCH 1/4] dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24 bindings

[Jakob Hauser]

Hi Rob,

On 11.10.24 16:27, Rob Herring wrote:
> On Thu, Oct 10, 2024 at 08:31:48PM +0200, Jakob Hauser wrote:
> > Add bindings for Samsung AMS427AP24 panel with S6E88A0 controller.
> >
> > Signed-off-by: Jakob Hauser <jahau@xxxxxxxxxxxxxx>
> > ---
> > Patch is based on https://gitlab.freedesktop.org/drm/misc/kernel.git
> > current branch drm-misc-next.
> > ---
> >   .../panel/samsung,s6e88a0-ams427ap24.yaml     | 68 +++++++++++++++++++
> >   1 file changed, 68 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams427ap24.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams427ap24.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams427ap24.yaml
> > new file mode 100644
> > index 000000000000..7010d3bbd07f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams427ap24.yaml
> > @@ -0,0 +1,68 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/samsung,s6e88a0-ams427ap24.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Samsung AMS427AP24 panel with S6E88A0 controller
> > +
> > +maintainers:
> > +  - Jakob Hauser <jahau@xxxxxxxxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: panel-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: samsung,s6e88a0-ams427ap24
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  port: true
> > +  reset-gpios: true
> > +
> > +  vdd3-supply:
> > +    description: core voltage supply
> > +
> > +  vci-supply:
> > +    description: voltage supply for analog circuits
> > +
> > +  flip-horizontal:
> > +    description: boolean to flip image horizontally
> > +    type: boolean
>
> This is already used in another panel. Please move it to
> panel-common.yaml.

I'll add a patch in v2 to move "flip-horizontal" and along with it also 
"flip-vertical" to "panel-common.yaml". File "samsung,s6e8aa0.yaml" 
needs to be changed accordingly.

@ Thierry, Laurent & Andrzej: CC'ing you as you're listed as maintainers 
of the affected files.

> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - port
> > +  - reset-gpios
> > +  - vdd3-supply
> > +  - vci-supply
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +
> > +    dsi {
> > +            #address-cells = <1>;
> > +            #size-cells = <0>;
> > +
> > +            panel@0 {
> > +                    compatible = "samsung,s6e88a0-ams427ap24";
> > +                    reg = <0>;
> > +
> > +                    vdd3-supply = <&pm8916_l17>;
> > +                    vci-supply = <&pm8916_l6>;
> > +                    reset-gpios = <&tlmm 25 GPIO_ACTIVE_LOW>;
> > +                    flip-horizontal;
> > +
> > +                    port {
> > +                            panel_in: endpoint {
> > +                                    remote-endpoint = <&mdss_dsi0_out>;
> > +                            };
> > +                    };
> > +            };
> > +    };
> > --
> > 2.39.5

Kind regards,
Jakob