Re: [PATCH 2/4] drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver

From: Jakob Hauser
Date: Fri Oct 11 2024 - 15:43:37 EST


Hi Jessica,

On 11.10.24 18:52, Jessica Zhang wrote:


On 10/10/2024 11:31 AM, Jakob Hauser wrote:

...

+struct s6e88a0_ams427ap24 {
+    struct drm_panel panel;
+    struct mipi_dsi_device *dsi;
+    struct regulator_bulk_data *supplies;
+    struct gpio_desc *reset_gpio;
+    bool prepared;

Hi Jakob,

I think you can drop the `prepared` here as it should be handled by framework now [1]

Thanks,

Jessica Zhang

[1] https://elixir.bootlin.com/linux/v6.11.3/source/include/drm/drm_panel.h#L262

+};

Thanks for the hint. I'll change that in v2.

...

Kind regards,
Jakob