Re: [PATCH] pinctrl: nuvoton: fix a double free in ma35_pinctrl_dt_node_to_map_func()

From: Linus Walleij
Date: Fri Oct 11 2024 - 15:56:00 EST


On Thu, Oct 10, 2024 at 10:52 PM Harshit Mogalapalli
<harshit.m.mogalapalli@xxxxxxxxxx> wrote:

> 'new_map' is allocated using devm_* which takes care of freeing the
> allocated data on device removal, call to
>
> .dt_free_map = pinconf_generic_dt_free_map
>
> double frees the map as pinconf_generic_dt_free_map() calls
> pinctrl_utils_free_map().
>
> Fix this by using kcalloc() instead of auto-managed devm_kcalloc().
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: f805e356313b ("pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver")
> Reported-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>

Patch applied for fixes.

Yours,
Linus Walleij