Re: [PATCH 1/2] arm64: dts: qcom: x1e80100-crd: enable otg on usb ports

[Dmitry Baryshkov]

On Fri, Oct 11, 2024 at 11:27:11AM -0400, Jonathan Marek wrote:
> The 3 USB ports on x1e80100-crd are OTG-capable, change dr_mode and add
> usb-role-switch flag to enable OTG.
> 
> Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> index 6dfc85eda3540..53e76b3f0c831 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
> @@ -1558,7 +1558,8 @@ &usb_1_ss0 {
>  };
>  
>  &usb_1_ss0_dwc3 {
> -	dr_mode = "host";
> +	dr_mode = "otg";

There should be no need to specify "otg", it is a default if I remember
correctly.

> +	usb-role-switch;

Please move usb-role-switch to the x1e80100.dtsi instead.

>  };
>  
>  &usb_1_ss0_dwc3_hs {
> @@ -1590,7 +1591,8 @@ &usb_1_ss1 {
>  };
>  
>  &usb_1_ss1_dwc3 {
> -	dr_mode = "host";
> +	dr_mode = "otg";
> +	usb-role-switch;
>  };
>  
>  &usb_1_ss1_dwc3_hs {
> @@ -1622,7 +1624,8 @@ &usb_1_ss2 {
>  };
>  
>  &usb_1_ss2_dwc3 {
> -	dr_mode = "host";
> +	dr_mode = "otg";
> +	usb-role-switch;
>  };
>  
>  &usb_1_ss2_dwc3_hs {
> -- 
> 2.45.1
> 

-- 
With best wishes
Dmitry