Re: [PATCH net-next] net: vlan: Use vlan_prio instead of vlan_qos in mapping
From: Jakub Kicinski
Date: Fri Oct 11 2024 - 18:49:29 EST
On Wed, 9 Oct 2024 21:23:02 +0800 Yajun Deng wrote:
> The vlan_qos member is used to save the vlan qos, but we only save the
> priority. Also, we will get the priority in vlan netlink and proc.
> So we can just save the vlan priority using vlan_prio.
>
> Defined VLAN_PRIO_MAX to limit the vlan priority to a maximum of 7.
> For flexibility, we introduced vlan_dev_get_egress_priority helper
> function.
The motivation is not clear, you don't explain how you tested, and
haven't added any selftests.
--
pw-bot: cr