Re: [PATCH 1/3] KVM: x86, vmx: Add function for event delivery error generation

From: Sean Christopherson
Date: Fri Oct 11 2024 - 20:06:48 EST


On Fri, Oct 11, 2024, Sean Christopherson wrote:
> > + kvm_x86_call(get_exit_info)(vcpu, &reason, &info1, &info2, &intr_info, &error_code);
>
> Wrap. Though calling back into vendor code is silly. Pass the necessary info
> as parameters. E.g. error_code and intr_info are unused, so the above is wasteful
> and weird.

Ah, but the next patch invokes this from common code, i.e. can't pass in the
necessary info. _That_ is definitely worth calling out in the changelog.