RE: [PATCH v15] pwm: opencores: Add PWM driver support

From: William Qiu
Date: Sat Oct 12 2024 - 04:03:07 EST




> -----Original Message-----
> From: William Qiu
> Sent: 2024年10月11日 18:43
> To: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-pwm@xxxxxxxxxxxxxxx; Hal Feng
> <hal.feng@xxxxxxxxxxxxxxxx>; Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> Subject: RE: [PATCH v15] pwm: opencores: Add PWM driver support
>
> > +static void __iomem *starfive_get_ch_base(void __iomem *base,
> + unsigned int channel)
> >
> > Would be great if all functions had the same prefix. This simplifies
> > debugging with tracing, because you can just enable traces for
> "ocores_pwm_*".
> >
> Will update.

I want to explain something about this. This interface only works on
StarFive boards, so the "starfive" prefix is used, I don't think the
"ocores_pwm" prefix is appropriate here.

Uwe, what do you think?

Best Regards,
William