Re: [PATCH 1/2] media: dt-bindings: Remove assigned-clock-* from various schema

[Laurent Pinchart]

Hi Bryan,

Thank you for the patch.

On Sat, Oct 12, 2024 at 04:02:50PM +0100, Bryan O'Donoghue wrote:
> Remove extraneous assigned-clock* from media/i2c/* schemas, retain in the
> relevant examples.

You may want to explain in the commit message *why* you're doing this.
The reason may not be straightforward for everybody. With that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> 
> Link: https://lore.kernel.org/linux-media/j7kgz2lyxnler5qwd7yiazdq6fmsv77kyozdrxf33h54ydakjz@uqjhwhoyv6re
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 8 --------
>  Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml | 8 --------
>  Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml | 8 --------
>  Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml | 4 ----
>  Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml | 4 ----
>  Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml | 4 ----
>  Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml | 4 ----
>  Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml | 4 ----
>  8 files changed, 44 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> index 60f19e1152b33128cf3baa15b8c70a874ca6d52e..d18ead8f7fc43bfacc291aed85b5ca9166c46edb 100644
> --- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml
> @@ -28,12 +28,6 @@ properties:
>      items:
>        - description: Reference to the mclk clock.
>  
> -  assigned-clocks:
> -    maxItems: 1
> -
> -  assigned-clock-rates:
> -    maxItems: 1
> -
>    reset-gpios:
>      description: Reference to the GPIO connected to the RESETB pin. Active low.
>      maxItems: 1
> @@ -82,8 +76,6 @@ required:
>    - compatible
>    - reg
>    - clocks
> -  - assigned-clocks
> -  - assigned-clock-rates
>    - vddio-supply
>    - vdda-supply
>    - vddd-supply
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml
> index 1f497679168c8395a94b3867beb49b251ef621fc..622243cae03caa5d14aa312df40ef5907e190d2c 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml
> @@ -20,12 +20,6 @@ properties:
>      items:
>        - description: XVCLK Clock
>  
> -  assigned-clocks:
> -    maxItems: 1
> -
> -  assigned-clock-rates:
> -    maxItems: 1
> -
>    dvdd-supply:
>      description: Digital Domain Power Supply
>  
> @@ -68,8 +62,6 @@ required:
>    - compatible
>    - reg
>    - clocks
> -  - assigned-clocks
> -  - assigned-clock-rates
>    - dvdd-supply
>    - dovdd-supply
>    - port
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
> index 8a70e23ba6abed67d8b61c33bd7a261089bddda2..382d7de7a89bcea11be384a2a3800512994f9346 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml
> @@ -20,12 +20,6 @@ properties:
>      items:
>        - description: EXTCLK Clock
>  
> -  assigned-clocks:
> -    maxItems: 1
> -
> -  assigned-clock-rates:
> -    maxItems: 1
> -
>    dvdd-supply:
>      description: Digital Domain Power Supply
>  
> @@ -68,8 +62,6 @@ required:
>    - compatible
>    - reg
>    - clocks
> -  - assigned-clocks
> -  - assigned-clock-rates
>    - dvdd-supply
>    - avdd-supply
>    - dovdd-supply
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
> index 79a7658f6d0547e4d6fb2267e5757eedf49fd416..38325cf318f7bd2cd60a4c7bbb6a65b54b855e26 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
> @@ -27,10 +27,6 @@ properties:
>      description: I2C address
>      maxItems: 1
>  
> -  assigned-clocks: true
> -  assigned-clock-parents: true
> -  assigned-clock-rates: true
> -
>    clocks:
>      description: Clock frequency from 6 to 27MHz
>      maxItems: 1
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
> index c978abc0cdb35cfe2b85069946cf1be435a58cb8..f0f9726a2add89492b8c56e17ed607841baa3a0d 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml
> @@ -24,10 +24,6 @@ properties:
>        - sony,imx258
>        - sony,imx258-pdaf
>  
> -  assigned-clocks: true
> -  assigned-clock-parents: true
> -  assigned-clock-rates: true
> -
>    clocks:
>      description:
>        Clock frequency from 6 to 27 MHz.
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> index bce57b22f7b63bd73f08d8831d9bb04858ef03e0..872b8288948b2bba743f2365a55165181df156ae 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
> @@ -24,10 +24,6 @@ properties:
>      description: I2C address
>      maxItems: 1
>  
> -  assigned-clocks: true
> -  assigned-clock-parents: true
> -  assigned-clock-rates: true
> -
>    clocks:
>      description: Clock frequency from 6 to 27 MHz, 37.125MHz, 74.25MHz
>      maxItems: 1
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> index 77bf3a4ee89db3b5d16149470c0380ef8f1aeac1..38bd1c7304a59bb5fea90954c1e4e626a7c86f2f 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
> @@ -24,10 +24,6 @@ properties:
>      description: I2C address
>      maxItems: 1
>  
> -  assigned-clocks: true
> -  assigned-clock-parents: true
> -  assigned-clock-rates: true
> -
>    clocks:
>      description: Clock frequency from 6 to 27 MHz, 37.125MHz, 74.25MHz
>      maxItems: 1
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
> index d9b7815650fdb890418fc96c828acc9147dfb6e8..ece1e17fe34553671e61c965eb1833c5eb08131b 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
> @@ -26,10 +26,6 @@ properties:
>      description: I2C address
>      maxItems: 1
>  
> -  assigned-clocks: true
> -  assigned-clock-parents: true
> -  assigned-clock-rates: true
> -
>    clocks:
>      description: Clock frequency 6MHz, 12MHz, 18MHz, 24MHz or 27MHz
>      maxItems: 1

-- 
Regards,

Laurent Pinchart