Re: [RFC PATCH net-next] net: dsa: vsc73xx: remove ds->untag_bridge_pvid request

[Paweł Dembicki]

wt., 8 paź 2024 o 12:47 Vladimir Oltean <vladimir.oltean@xxxxxxx> napisał(a):
>
> Similar to the situation described for sja1105 in commit 1f9fc48fd302
> ("net: dsa: sja1105: fix reception from VLAN-unaware bridges") from the
> 'net' tree, the vsc73xx driver uses tag_8021q.
>
> The ds->untag_bridge_pvid option strips VLANs from packets received on
> VLAN-unaware bridge ports. But those VLANs should already be stripped by
> tag_vsc73xx_8021q.c as part of vsc73xx_rcv(). It is even plausible that
> the same bug that existed for sja1105 also exists for vsc73xx:
> dsa_software_untag_vlan_unaware_bridge() tries to untag a VLAN that
> doesn't exist, corrupting the packet.
>
> Only compile tested, as I don't have access to the hardware.
>

Thanks Vladimir for this patch. This fix is required for the proper
functioning of vsc73xx.

Tested-by: Pawel Dembicki <paweldembicki@xxxxxxxxx>