Re: [PATCH net-next 2/3] connector/cn_proc: Kunit tests for threads hash table

[Anjali Kulkarni]

________________________________________
From: Simon Horman <horms@xxxxxxxxxx>
Sent: Saturday, October 12, 2024 2:45 AM
To: Anjali Kulkarni
Cc: davem@xxxxxxxxxxxxx; Liam Howlett; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; mingo@xxxxxxxxxx; peterz@xxxxxxxxxxxxx; juri.lelli@xxxxxxxxxx; vincent.guittot@xxxxxxxxxx; dietmar.eggemann@xxxxxxx; rostedt@xxxxxxxxxxx; bsegall@xxxxxxxxxx; mgorman@xxxxxxx; vschneid@xxxxxxxxxx; jiri@xxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; shuah@xxxxxxxxxx; linux-kselftest@xxxxxxxxxxxxxxx; Pei Li
Subject: Re: [PATCH net-next 2/3] connector/cn_proc: Kunit tests for threads hash table

On Fri, Oct 11, 2024 at 05:45:31PM -0700, Anjali Kulkarni wrote:
> Kunit tests to test hash table add, delete, duplicate add and delete.
> Add following configs and compile kernel code:
>
> CONFIG_CONNECTOR=y
> CONFIG_PROC_EVENTS=y
> CONFIG_NET=y
> CONFIG_KUNIT=m/y
> CONFIG_CN_HASH_KUNIT_TEST=m/y
>
> To run kunit tests:
> sudo modprobe cn_hash_test
>
> Output of kunit tests and hash table contents are displayed in
> /var/log/messages (at KERN_DEBUG level).
>
> Signed-off-by: Anjali Kulkarni <anjali.k.kulkarni@xxxxxxxxxx>

...

> index 000000000000..2687492864ed
> --- /dev/null
> +++ b/lib/cn_hash_test.c
> @@ -0,0 +1,167 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * KUnit test for the connector threads hashtable code.
> + *
> + * Copyright (c) 2024 Oracle and/or its affiliates.
> + * Author: Anjali Kulkarni <anjali.k.kulkarni@xxxxxxxxxx>
> + */
> +#include <kunit/test.h>
> +
> +#include "cn_hash_test.h"
> +
> +#define ARR_SIZE     4
> +#define HASH_TABLE_LEN       1024
> +
> +struct add_data {
> +     pid_t pid;
> +     int exit_val;
> +     int key;
> +};
> +
> +struct add_data adata[ARR_SIZE];
> +int key_display[HASH_TABLE_LEN];

Hi Anjali,

adata and key_display seem to only be used within this file.
Probably they should be static.

Anjali> Thanks! Yes, will do both changes you have suggested and send in new revision.

Anjali

...