Re: [PATCH 1/2] ALSA: emu10k1: add a capability bit for no MIDI

[Oswald Buddenhagen]

On Sun, Oct 13, 2024 at 09:47:12AM +0800, Icenowy Zheng wrote:
> +++ b/sound/pci/emu10k1/emu10k1.c
> @@ -133,7 +133,9 @@ static int snd_card_emu10k1_probe(struct pci_dev *pci,
> 		if (err < 0)
> 			return err;
> 	}
> -	if (emu->audigy) {
> +	if (emu->card_capabilities->no_midi) {
> +		dev_info(emu->card->dev, "Card has no ext. MIDI ports.\n");
seems like excess verbosity. there are much more important things that
are not reported.

> +	} else if (emu->audigy) {
i would eliminate that, and instead populate the card table properly.
that's a bit more code, but it's more uniform, and the resulting binary
is even a tiny bit smaller.

also, i would squash the patches, as i see no point in having them
separate, given their size.

regards