Re: [PATCH net-next v7 09/12] net: vxlan: add drop reasons support to vxlan_xmit_one()

From: Ido Schimmel
Date: Sun Oct 13 2024 - 09:18:18 EST


On Wed, Oct 09, 2024 at 10:28:27AM +0800, Menglong Dong wrote:
> Replace kfree_skb/dev_kfree_skb with kfree_skb_reason in vxlan_xmit_one.
> No drop reasons are introduced in this commit.
>
> The only concern of mine is replacing dev_kfree_skb with
> kfree_skb_reason. The dev_kfree_skb is equal to consume_skb, and I'm not
> sure if we can change it to kfree_skb here. In my option, the skb is
> "dropped" here, isn't it?
>
> Signed-off-by: Menglong Dong <dongml2@xxxxxxxxxxxxxxx>
> Reviewed-by: Simon Horman <horms@xxxxxxxxxx>

Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx>