Re: [PATCH v3 1/3] perf probe: Use the MAX_EVENT_NAME_LEN macro

[Google]

On Sat, 12 Oct 2024 21:47:23 +0100
Leo Yan <leo.yan@xxxxxxx> wrote:

> The MAX_EVENT_NAME_LEN macro has been defined in the kernel. Use the
> same definition in the tool for more readable.
> 

Looks good to me. Thanks!

Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>

> Signed-off-by: Leo Yan <leo.yan@xxxxxxx>
> ---
>  tools/perf/util/probe-event.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index a17c9b8a7a79..061a0412dec2 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -51,6 +51,9 @@
>  
>  #define PERFPROBE_GROUP "probe"
>  
> +/* Defined in kernel/trace/trace.h */
> +#define MAX_EVENT_NAME_LEN	64
> +
>  bool probe_event_dry_run;	/* Dry run flag */
>  struct probe_conf probe_conf = { .magic_num = DEFAULT_PROBE_MAGIC_NUM };
>  
> @@ -2841,7 +2844,7 @@ static int probe_trace_event__set_name(struct probe_trace_event *tev,
>  				       bool allow_suffix)
>  {
>  	const char *event, *group;
> -	char buf[64];
> +	char buf[MAX_EVENT_NAME_LEN];
>  	int ret;
>  
>  	/* If probe_event or trace_event already have the name, reuse it */
> -- 
> 2.25.1
> 


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>