Re: [PATCH] tools/resolve_btfids: Fix 'variable' may be used uninitialized warnings

From: Sam James
Date: Sun Oct 13 2024 - 20:58:21 EST


Eder Zulian <ezulian@xxxxxxxxxx> writes:

> Hi Sam, thank you for pointing it out.
>
> On Sat, Oct 12, 2024 at 05:14:29AM +0100, Sam James wrote:
>> The parse-options change was sent before as
>> https://lore.kernel.org/all/20240731085217.94928-1-michael.weiss@xxxxxxxxxxxxxxxxxxx/
>
> Sorry, I missed Michael's patch.
> My suggestion is to initialize 'o' to NULL instead. An illegal dereferencing
> (if any) would then be evident.

Yeah, I was wondering the same.

>
>> but seems to have fallen through the cracks.
>>
>>
> Would it be better to revert this part and wait a bit for Michael's patch to
> be merged, please let me know.

I'll defer to the maintainers.

>
> Thank you,
> Eder