Re: [PATCH 2/2] drm/msm: add another DRM_DISPLAY_DSC_HELPER selection

From: Abhinav Kumar
Date: Sun Oct 13 2024 - 23:20:59 EST




On 10/13/2024 8:11 PM, Abhinav Kumar wrote:


On 9/4/2024 8:08 PM, Dmitry Baryshkov wrote:
In the drm/msm driver both DSI and DPU subdrivers use drm_dsc_*
functions, but only DSI selects DRM_DISPLAY_DSC_HELPER symbol. Add
missing select to the DPU subdriver too.

Fixes: ca097d4d94d8 ("drm/display: split DSC helpers from DP helpers")
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-kbuild-all/202409040129.rqhtRTeC-lkp@xxxxxxxxx/
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
  drivers/gpu/drm/msm/Kconfig | 1 +
  1 file changed, 1 insertion(+)


Change LGTM, hence

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>

But, ca097d4d94d8 ("drm/display: split DSC helpers from DP helpers") is not yet merged, so I will not be able to pick this up for this cycle?


Please ignore, I just noticed this series was applied through drm-misc.

diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
index 94d3ed4f7761..c8dda0ebd043 100644
--- a/drivers/gpu/drm/msm/Kconfig
+++ b/drivers/gpu/drm/msm/Kconfig
@@ -92,6 +92,7 @@ config DRM_MSM_DPU
      bool "Enable DPU support in MSM DRM driver"
      depends on DRM_MSM
      select DRM_MSM_MDSS
+    select DRM_DISPLAY_DSC_HELPER
      default y
      help
        Compile in support for the Display Processing Unit in