Re: [PATCH 2/2] media: dt-bindings: Use additionalProperties: false for endpoint: properties:

[Krzysztof Kozlowski]

On Sat, Oct 12, 2024 at 04:02:51PM +0100, Bryan O'Donoghue wrote:
> Some of our sensor schemas use unevaluatedProperities: false for endpoint:
> properties: while other schemas use additionalProperties: false.
> 
> The effect of using unevaluatedProperities: false in this instance is that
> any property in media/video-interfaces.yaml can be considered in a dts for
> an endpoint.

... which is what we want and what is expected.

You change the code from expected to less expected variant, so please
clearly document why.

> 
> Converting to additionalProperties: false and running DT checkers show that
> such a liberal policy is unnecessary.
> 
> We should have a consistent way of defining these properties if for no
> other reason than aid other developers in the preferred way of writing
> these schemas for media/i2c in the future.

There is consistent way - common schema defines them.

I do not understand the reasoning behind this change at all. I don't
think DT maintainers ever suggested it (in fact, rather opposite:
suggested using unevaluatedProps) and I think is not a consensus of any
talks.

Best regards,
Krzysztof