Re: [PATCH v2 5/6] gpiolib: switch the line state notifier to atomic
From: Bartosz Golaszewski
Date: Mon Oct 14 2024 - 03:48:38 EST
On Mon, Oct 14, 2024 at 4:11 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> >
> > + /*
> > + * This is called from atomic context (with a spinlock taken by the
> > + * atomic notifier chain). Any sleeping calls must be done outside of
> > + * this function in process context of the dedicated workqueue.
> > + *
> > + * Let's gather as much info as possible from the descriptor and
> > + * postpone just the call to pinctrl_gpio_can_use_line() until the work
> > + * is executed.
> > + */
> > +
>
> Should be in patch 4? You aren't otherwise changing that function here.
>
Until this patch, the comment isn't really true, so I figured it makes
more sense here.
Bart