Re: [PATCH v6 6/8] dt-bindings: pinctrl: mediatek: Add bindings for MT6735 pin controller

[AngeloGioacchino Del Regno]

Il 11/10/24 14:03, Yassine Oudjana ha scritto:
> From: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
>
> Add DT bindings for the MT6735 pin controller, which consist of macros
> to be used as values for the pinmux property. Each macro corresponds
> to a unique possible pin-function combination.
>
> Signed-off-by: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
> ---
>   MAINTAINERS                                   |    6 +
>   .../pinctrl/mediatek,mt6735-pinctrl.h         | 1148 +++++++++++++++++
>   2 files changed, 1154 insertions(+)
>   create mode 100644 include/dt-bindings/pinctrl/mediatek,mt6735-pinctrl.h
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e336dab6fdd1a..f95ae886f9fd8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18311,6 +18311,12 @@ F:	drivers/pinctrl/mediatek/pinctrl-rt2880.c
>   F:	drivers/pinctrl/mediatek/pinctrl-rt305x.c
>   F:	drivers/pinctrl/mediatek/pinctrl-rt3883.c
>   
> +PIN CONTROLLER - MEDIATEK MT6735
> +M:	Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
> +L:	linux-mediatek@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
> +S:	Maintained
> +F:	include/dt-bindings/pinctrl/mediatek,mt6735-pinctrl.h
> +
>   PIN CONTROLLER - MICROCHIP AT91
>   M:	Ludovic Desroches <ludovic.desroches@xxxxxxxxxxxxx>
>   L:	linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
> diff --git a/include/dt-bindings/pinctrl/mediatek,mt6735-pinctrl.h b/include/dt-bindings/pinctrl/mediatek,mt6735-pinctrl.h
> new file mode 100644
> index 0000000000000..1134caf9022c5
> --- /dev/null
> +++ b/include/dt-bindings/pinctrl/mediatek,mt6735-pinctrl.h

They're all called "pinfunc", even the newest mt8188 one, so please:

mediatek,mt6735-pinfunc.h

just for consistency and nothing else

> @@ -0,0 +1,1148 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (C) 2022 Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx>
> + */
> +
> +#ifndef __DT_BINDINGS_PINCTRL_MEDIATEK_MT6735_PINFUNC_H__
> +#define __DT_BINDINGS_PINCTRL_MEDIATEK_MT6735_PINFUNC_H__

#ifndef _DT_BINDINGS_PINCTRL_MEDIATEK_MT6735_PINFUNC_H
#define _DT_BINDINGS_PINCTRL_MEDIATEK_MT6735_PINFUNC_H

#endif /* _DT_BINDINGS_PINCTRL_MEDIATEK_MT6735_PINFUNC_H */

Cheers,
Angelo