Re: [PATCH net-next 1/1] net: phy: Refactor mediatek-ge-soc.c for clarity and correctness

[Simon Horman]

On Mon, Oct 14, 2024 at 12:05:21PM +0800, Sky Huang wrote:
> From: "SkyLake.Huang" <skylake.huang@xxxxxxxxxxxx>
> 
> This patch does the following clean-up:
> 1. Fix spelling errors and rearrange variables with reverse
>    Xmas tree order.
> 2. Shrink mtk-ge-soc.c line wrapping to 80 characters.
> 3. Propagate error code correctly in cal_cycle().
> 4. Fix some functions with FIELD_PREP()/FIELD_GET().
> 5. Remove unnecessary outer parens of supported_triggers var.
> 
> Signed-off-by: SkyLake.Huang <skylake.huang@xxxxxxxxxxxx>
> ---
> This patch is derived from Message ID:
> 20241004102413.5838-9-SkyLake.Huang@xxxxxxxxxxxx

Hi Sky,

I think this patch is trying to do two many things (at least 5 are listed
above). Please consider breaking this up into separate patches, perhaps
one for each of the points above.

Also, I think it would be best to drop the following changes unless you are
touching those lines for some other reason [1] or are preparing to do so:

* xmas tree
* 80 character lines
* parentheses updates

[1] https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches