Re: [PATCH v4 0/6] thermal: scope/cleanup.h improvements

From: Chen-Yu Tsai
Date: Mon Oct 14 2024 - 04:34:39 EST


On Fri, Oct 11, 2024 at 2:06 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> Changes in v4:
> - Patch 2: rewrite, significant change: kzalloc() also with
> scoped-handling so the entire error handling could be removed.
> Due to above, drop review-tags (Chen-Yu, Jonathan).
> - Add Rb tags for other patches.
> - Link to v3: https://lore.kernel.org/r/20241008-b4-cleanup-h-of-node-put-thermal-v3-0-825122398f71@xxxxxxxxxx
>
> Changes in v3:
> - Rebase, because there was bigger rework in thermal code.
> This made two patches obsolete, but brought new one:
> 1/6: thermal: of: Simplify thermal_of_should_bind with scoped for each OF child
> - Link to v2: https://lore.kernel.org/r/20240816-b4-cleanup-h-of-node-put-thermal-v2-0-cee9fc490478@xxxxxxxxxx
>
> Changes in v2:
> - Drop left-over of_node_put in regular exit path (Chen-Yu)
> - Link to v1: https://lore.kernel.org/r/20240814-b4-cleanup-h-of-node-put-thermal-v1-0-7a1381e1627e@xxxxxxxxxx
>
> Few code simplifications with scope/cleanup.h.
>
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (6):
> thermal: of: Simplify thermal_of_should_bind with scoped for each OF child

I couldn't find this in my inbox. But since I already reviewed all the other
patches, and I looked at this one on lore, consider the whole series is now

Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>

> thermal: of: Use scoped memory and OF handling to simplify thermal_of_trips_init()
> thermal: of: Use scoped device node handling to simplify of_thermal_zone_find()
> thermal: qcom-spmi-adc-tm5: Simplify with scoped for each OF child loop
> thermal: tegra: Simplify with scoped for each OF child loop
> thermal: sun8i: Use scoped device node handling to simplify error paths
>
> drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 7 ++---
> drivers/thermal/sun8i_thermal.c | 11 +++----
> drivers/thermal/tegra/soctherm.c | 5 ++-
> drivers/thermal/thermal_of.c | 54 ++++++++++----------------------
> 4 files changed, 25 insertions(+), 52 deletions(-)
> ---
> base-commit: 33ce24234fca4c083e6685a18b460a18ebb5d5c1
> change-id: 20240814-b4-cleanup-h-of-node-put-thermal-2268440cc6f7
>
> Best regards,
> --
> Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>