Re: [PATCH 0/2] s390: two bugfixes (for kunit)

From: Sven Schnelle
Date: Mon Oct 14 2024 - 04:55:46 EST


Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx> writes:

> When trying to use kunit for s390 with
> ./tools/testing/kunit/kunit.py run --arch=s390 --kunitconfig drivers/base/test --cross_compile=$CROSS_COMPILE
> I ran into some bugs.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> ---
> Thomas Weißschuh (2):
> s390/sclp: deactivate sclp after all its users
> s390/sclp_vt220: convert newlines to CRLF instead of LFCR
>
> drivers/s390/char/sclp.c | 3 ++-
> drivers/s390/char/sclp_vt220.c | 4 ++--
> 2 files changed, 4 insertions(+), 3 deletions(-)
> ---
> base-commit: 6485cf5ea253d40d507cd71253c9568c5470cd27
> change-id: 20241014-s390-kunit-47cbc26a99e6

Looks good to me. For both patches:

Reviewed-by: Sven Schnelle <svens@xxxxxxxxxxxxx>

Thanks!
Sven