Re: [PATCH] staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node

From: Dan Carpenter
Date: Mon Oct 14 2024 - 05:07:42 EST


On Mon, Oct 14, 2024 at 10:49:28AM +0200, Javier Carrasco wrote:
> In this particular case, and as Greg pointed out, that is not a real
> threat anyway. My digression comes to an end, and v2 is on its way.
>

I mean the other thing that we would accept is if you moved the NULL check to
be the first thing after the declaration block...

regards,
dan carpenter