Re: [PATCH 1/7] drm/panic: avoid reimplementing Iterator::find

[Jocelyn Falempe]

On 12/10/2024 13:04, Miguel Ojeda wrote:
> Hi Thomas,
>
> These commit logs are nicely explained -- thanks a lot for taking the
> time to write each!
>
> A couple nits below.
>
> On Sat, Oct 12, 2024 at 9:53 AM Thomas Böhler <witcher@xxxxxxxxxxxxx> wrote:
> > implementing the same logic itself.
> > Clippy complains about this in the `manual_find` lint:
>
> Typically commit messages use newlines between paragraphs.
>
> > Reported-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> > Closes: https://github.com/Rust-for-Linux/linux/issues/1123
>
> Since each of these commits fixes part of the issue, I think these are
> meant to be `Link:`s instead of `Closes:`s according to the docs:
>
>      https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
>
> In addition, these should probably have a `Fixes:` tag too -- I should
> have mentioned that in the issue, sorry.
>
> Finally, as a suggestion for the future: for a series like this, it
> may make sense to have a small/quick cover letter saying something as
> simple as: "Clippy reports some issues in ... -- this series cleans
> them up.". Having a cover letter also allows you to give a title to
> the series.

Hi Thomas,

If you want to send a v2, the easiest way is to download the mbox series 
from https://patchwork.freedesktop.org/series/139924/
and apply it with git am.

That way you will have my reviewed-by automatically added.

I can push this series through drm-misc-next if needed.

Best regards,

--

Jocelyn

> Thanks again!
>
> Cheers,
> Miguel