Re: [PATCH v2 0/2] efi/libstub: fix efi_parse_options() ignoring the default command line

From: Ard Biesheuvel
Date: Mon Oct 14 2024 - 05:55:38 EST


On Sun, 13 Oct 2024 at 21:25, Jonathan Marek <jonathan@xxxxxxxx> wrote:
>
> On 10/13/24 1:30 PM, Ard Biesheuvel wrote:
> > On Sun, 13 Oct 2024 at 07:16, Jonathan Marek <jonathan@xxxxxxxx> wrote:
> >>
> >> v2:
> >> - changed to check for NUL character instead of size==1
> >> - reworked cleanup patch to remove cmd_line_len
> >> - moved 3rd commit out of this series
> >>
> >> Jonathan Marek (2):
> >> efi/libstub: fix efi_parse_options() ignoring the default command line
> >> efi/libstub: remove unnecessary cmd_line_len from
> >> efi_convert_cmdline()
> >>
> >
> > Thanks. I'm inclined to fold these together and just merge them as a
> > single patch. Any objections?
> >
>
> No objections (its not important to me, but if you want to get the fix
> into stable I think the separate commits makes that easier?)

Yeah good point. I am not going to send these out as fixes anyway,
given that they affect boot behavior, and there are some other things
to fix.