Re: [PATCH 1/2] media: dt-bindings: Remove assigned-clock-* from various schema

[Bryan O'Donoghue]

On 14/10/2024 09:44, Krzysztof Kozlowski wrote:
> On 14/10/2024 10:29, Bryan O'Donoghue wrote:
> > On 14/10/2024 08:43, Krzysztof Kozlowski wrote:
> > > > -  - assigned-clocks
> > > > -  - assigned-clock-rates
> > > That's not extraneous, but has a meaning that without assigned-clocks
> > > this device or driver will not operate.
> > >
> > > File should rather stay as is.
> >
> > Hmm, I've obviously missed a trick here.
> >
> > I'll check it out.
>
> My response was probably not complete: this still might be extraneous,
> because maybe the driver/device do not care. But in general requiring
> assigned-clocks could have a meaning.

No I see what you mean

Even though assigned-clock* is a property of the SoC this driver..

drivers/media/i2c/hi846.c
        mclk_freq = clk_get_rate(hi846->clock);
        if (mclk_freq != 25000000)
                dev_warn(&client->dev,
                         "External clock freq should be 25000000, not 
%u.\n",
                         mclk_freq);

doesn't support setting the clock.

So it actually is a requirement, yes.

---
bod