Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages

From: Mike Rapoport
Date: Mon Oct 14 2024 - 09:13:09 EST


On Sun, Oct 13, 2024 at 10:55:25PM -0700, Christoph Hellwig wrote:
> On Sun, Oct 13, 2024 at 11:43:41AM +0300, Mike Rapoport wrote:
> > > But why? That's pretty different from our normal style of arch hooks,
> > > and introduces an indirect call in a security sensitive area.
> >
> > Will change to __weak hook.
>
> Isn't the callback required when using the large ROX page? I.e.
> shouldn't it be an unconditional callback and not a weak override?

I'll add a Kconfig option to ensure that an architecture that wants to use
large ROX pages has explicit callback for that.

--
Sincerely yours,
Mike.