Re: [PATCH] misc: misc_minor_alloc to allocate ids for all dynamic/misc dynamic minors

From: Greg KH
Date: Mon Oct 14 2024 - 09:20:07 EST


On Mon, Oct 14, 2024 at 01:14:16PM +0000, Vimal Agrawal wrote:
> misc_minor_alloc was allocating id for minor only in case of
> MISC_DYNAMIC_MINOR but misc_minor_free was always freeing ids
> using ida_free causing a mismatch and following
> warn:
> > > WARNING: CPU: 0 PID: 159 at lib/idr.c:525 ida_free+0x3e0/0x41f
> > > ida_free called for id=127 which is not allocated.
> > > <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
> ...
> > > [<60941eb4>] ida_free+0x3e0/0x41f
> > > [<605ac993>] misc_minor_free+0x3e/0xbc
> > > [<605acb82>] misc_deregister+0x171/0x1b3
>
> misc_minor_alloc is changed to allocate id from ida for all dynamic/
> misc dynamic minors
>
> Signed-off-by: Vimal Agrawal <vimal.agrawal@xxxxxxxxxx>

What commit id does this fix?

And I think we need a test for this somewhere, care to write a kunit
test?

thanks,

greg k-h