Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add Orange Pi 5b enum to Orange Pi 5 entry

From: Jimmy Hon
Date: Mon Oct 14 2024 - 13:06:41 EST


> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 687823e58c22..62bb6587da8f 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -1051,7 +1051,9 @@ properties:
>
> - description: Xunlong Orange Pi 5
> items:
> - - const: xunlong,orangepi-5
> + - enum:
> + - xunlong,orangepi-5
> + - xunlong,orangepi-5b
> - const: rockchip,rk3588s

As Krzysztof mentioned in v3. The binding commit should come before
the devicetree commit. You'll want to reorder your commits. Otherwise,
if you git bisect, you can get an error with only the devicetree
updates without the changes to the bindings.