Re: [PATCH v3] PCI: starfive: Enable PCIe controller's runtime PM before probing host bridge

From: Mayank Rana
Date: Mon Oct 14 2024 - 13:40:46 EST


Hi Bjorn

On 10/14/2024 10:23 AM, Bjorn Helgaas wrote:
On Mon, Oct 14, 2024 at 09:26:07AM -0700, Mayank Rana wrote:
PCIe controller device (i.e. PCIe starfive device) is parent to PCIe host
bridge device. To enable runtime PM of PCIe host bridge device (child
device), it is must to enable parent device's runtime PM to avoid seeing
the below warning from PM core:

pcie-starfive 940000000.pcie: Enabling runtime PM for inactive device
with active children

Fix this issue by enabling starfive pcie controller device's runtime PM
before calling pci_host_probe() in plda_pcie_host_init().

Tested-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
Signed-off-by: Mayank Rana <quic_mrana@xxxxxxxxxxx>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>

I want this in the same series as Krishna's patch to turn on runtime
PM of host bridges. That's how I know they need to be applied in
order. If they're not in the same series, they're likely to be
applied out of order.Thank you for quick response and suggestion.


Hi Krishna

Please add this proposed change as part of your changes to enable runtime PM of host bridges.

Regards,
Mayank