Re: [PATCH v4 1/2] arm64: dts: rockchip: Add rk3588-orangepi-5b device tree and refactor

[Jimmy Hon]

> +&sdhci {
> +       bus-width = <8>;
> +       no-sdio;
> +       no-sd;
> +       non-removable;
> +       max-frequency = <200000000>;
> +       mmc-hs400-1_8v;
> +       mmc-hs400-enhanced-strobe;
> +       status = "disabled";
> +};
This is good. SDHCI is disabled by default, so just the Orange Pi 5B
board can enable it.

>  &sfc {
>         pinctrl-names = "default";
>         pinctrl-0 = <&fspim0_pins>;
> -       status = "okay";
> +       status = "disabled";
This is good. SFC is disabled by default, so just the Orange Pi 5
board can enable it.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts
> new file mode 100644
> index 000000000000..55eee855cacc
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts
> @@ -0,0 +1,27 @@
> +
> +&sfc {
> +       status = "disabled";
> +};
Since this is disabled by default. So this is now redundant and should
be removed.

> +
> +&pcie2x1l2 {
> +       reset-gpios = <&gpio3 RK_PD1 GPIO_ACTIVE_HIGH>;
> +       status = "okay";
> +};
Do you want to defer this part for now, and include this with WiFi enablement?