Re: [PATCH] dmaengine: idxd: Move DSA/IAA device IDs to IDXD driver

[Fenghua Yu]

Hi, Vinod,

On 10/14/24 11:17, Vinod Koul wrote:
> On 04-10-24, 12:52, Fenghua Yu wrote:
> > Since the DSA/IAA device IDs are only used by the IDXD driver, there is
> > no need to define them as public IDs. Move their definitions to the IDXD
> > driver to limit their scope. This change helps reduce unnecessary
> > exposure of the device IDs in the global space, making the codebase
> > cleaner and better encapsulated.
>
> That is good
>
> > There is no functional change.
>
> Ok
>
> > Fixes: 4fecf944c051 ("dmaengine: idxd: Add new DSA and IAA device IDs for Diamond Rapids platform")
> > Fixes: f91f2a9879cc ("dmaengine: idxd: Add a new DSA device ID for Granite Rapids-D platform")
>
> How is this a fix?

Do you want me to remove the fixes message?

I can do that in v2 if you agree.

> > Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> > ---
> >   drivers/dma/idxd/registers.h | 4 ++++
> >   include/linux/pci_ids.h      | 3 ---
> >   2 files changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/dma/idxd/registers.h b/drivers/dma/idxd/registers.h
> > index e16dbf9ab324..c426511f2104 100644
> > --- a/drivers/dma/idxd/registers.h
> > +++ b/drivers/dma/idxd/registers.h
> > @@ -6,6 +6,10 @@
> >   #include <uapi/linux/idxd.h>
> >   
> >   /* PCI Config */
> > +#define PCI_DEVICE_ID_INTEL_DSA_GNRD	0x11fb
> > +#define PCI_DEVICE_ID_INTEL_DSA_DMR	0x1212
> > +#define PCI_DEVICE_ID_INTEL_IAA_DMR	0x1216
> > +
> >   #define DEVICE_VERSION_1		0x100
> >   #define DEVICE_VERSION_2		0x200
> >   
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index 4cf6aaed5f35..e4bddb927795 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -2709,9 +2709,6 @@
> >   #define PCI_DEVICE_ID_INTEL_82815_MC	0x1130
> >   #define PCI_DEVICE_ID_INTEL_82815_CGC	0x1132
> >   #define PCI_DEVICE_ID_INTEL_SST_TNG	0x119a
> > -#define PCI_DEVICE_ID_INTEL_DSA_GNRD	0x11fb
> > -#define PCI_DEVICE_ID_INTEL_DSA_DMR	0x1212
> > -#define PCI_DEVICE_ID_INTEL_IAA_DMR	0x1216
> >   #define PCI_DEVICE_ID_INTEL_82092AA_0	0x1221
> >   #define PCI_DEVICE_ID_INTEL_82437	0x122d
> >   #define PCI_DEVICE_ID_INTEL_82371FB_0	0x122e
> > --
> > 2.37.1

Thanks.

-Fenghua