Re: [PATCH v2 2/2] drm/msm/dsi: fix 32-bit signed integer extension in pclk_rate calculation

[Abhinav Kumar]

On 10/6/2024 10:01 PM, Jonathan Marek wrote:
> When (mode->clock * 1000) is larger than (1<<31), int to unsigned long
> conversion will sign extend the int to 64 bits and the pclk_rate value
> will be incorrect.
>
> Fix this by making the result of the multiplication unsigned.
>
> Note that above (1<<32) would still be broken and require more changes, but
> its unlikely anyone will need that anytime soon.
>
> Fixes: c4d8cfe516dc ("drm/msm/dsi: add implementation for helper functions")
> Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx>
> ---
>   drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>