Re: [PATCH net-next v3 3/9] Bluetooth: RFCOMM: avoid leaving dangling sk pointer in rfcomm_sock_alloc()

From: Kuniyuki Iwashima
Date: Mon Oct 14 2024 - 17:30:25 EST


From: Ignat Korchagin <ignat@xxxxxxxxxxxxxx>
Date: Mon, 14 Oct 2024 16:38:02 +0100
> bt_sock_alloc() attaches allocated sk object to the provided sock object.
> If rfcomm_dlc_alloc() fails, we release the sk object, but leave the
> dangling pointer in the sock object, which may cause use-after-free.
>
> Fix this by swapping calls to bt_sock_alloc() and rfcomm_dlc_alloc().
>
> Signed-off-by: Ignat Korchagin <ignat@xxxxxxxxxxxxxx>

Reviewed-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>