Re: [PATCHv2 net] usbnet: modern method to get random MAC

From: Oliver Neukum
Date: Mon Oct 14 2024 - 18:24:49 EST


On 14.10.24 21:59, Eric Dumazet wrote:

As diagnosed by John Sperbeck :

This patch implies all ->bind() method took care of populating net->dev_addr ?

Otherwise the following existing heuristic is no longer working

// heuristic: "usb%d" for links we know are two-host,
// else "eth%d" when there's reasonable doubt. userspace
// can rename the link if it knows better.
if ((dev->driver_info->flags & FLAG_ETHER) != 0 &&
((dev->driver_info->flags & FLAG_POINTTOPOINT) == 0 ||
(net->dev_addr [0] & 0x02) == 0))
strscpy(net->name, "eth%d", sizeof(net->name));


Hi,

you need to have a MAC to be an ethernet device, don't you?

Regards
Oliver